Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More explicit setup for tests #5977

Merged
merged 3 commits into from Jul 23, 2019
Merged

More explicit setup for tests #5977

merged 3 commits into from Jul 23, 2019

Conversation

stsewd
Copy link
Member

@stsewd stsewd commented Jul 23, 2019

This makes these tests pass in the corporate site, we are relying in the default value (public), but in the corporate site this is private.

@stsewd
Be more explicit on test
b3d2ee1 
Default privacy level change in the corporate site,
it fixes a test.
@stsewd
Fix another test
486cb3c
@stsewd
Spaaace!
5d7b449
@stsewd stsewd added the PR: work in progress Pull request is not ready for full review label Jul 23, 2019
@stsewd
Copy link
Member Author

stsewd commented Jul 23, 2019

Wip, I'm still finding more of these :)

@stsewd
Copy link
Member Author

stsewd commented Jul 23, 2019

Looks good to go

@stsewd stsewd removed the PR: work in progress Pull request is not ready for full review label Jul 23, 2019
@stsewd stsewd requested a review from a team July 23, 2019 01:27
@stsewd stsewd merged commit 728b790 into readthedocs:master Jul 23, 2019
@stsewd stsewd deleted the more-explicit-setup branch July 23, 2019 01:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericholscher ericholscher ericholscher approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@stsewd @ericholscher